Goktug Gokdogan has posted comments on this change.
Change subject: Add interfaces for widgets.
......................................................................
Patch Set 8:
The part that I'm not comfortable with is, you can exactly have the same
effect with the current state.
Yes you wouldn't have compiler support but I don't think you it is a big
deal. Stub are going to be written once and you already did that. If a new
method is added and if somebody calls it, if will fail-fast; and you can
fix that yourself in your own code. With the interfaces, if someone forgets
to add the new method to interface and then you will need a patch to gwt
proper.
Being said that, rest assured, I wouldn't -1 for just not using it. My
point was, what I suggested looked like pretty feasible and acceptable for
your use case. If other reviewers +1's, you can go ahead submit the patch.
--
To view, visit https://gwt-review.googlesource.com/3231
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd17162d37e367720829bcdaf9a350e446c833b9
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman <stephen.haber...@gmail.com>
Gerrit-Reviewer: Colin Alworth <niloc...@gmail.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Stephen Haberman <stephen.haber...@gmail.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
