Colin Alworth has posted comments on this change.
Change subject: Add interfaces for widgets.
......................................................................
Patch Set 8:
What is the thinking for the remaining 10%-ish of widgets - all of the cell
widgets (except CellPanel), remaining *boxes (DateBox, various number-Box),
RichTextArea, missing *LayoutPanels (SplitLayoutPanel, LayoutPanel,
HeaderPanel, DeckLayoutPanel), etc? Future patch, or less important? I
could see skipping most of the boxes, since the api should be relatively
similar since subclasses mostly modify internal behavior, but then you have
IsNumberLabel which just makes the generics more explicit (and should
almost certainly be extending IsValueLabel to get those other
super-interfaces...). Then there are the layout panels which arguably look
like HasWidgets.ForIsWidget, but if IsElement gets so specific as to allow
direct dom manipulation, it seems reasonable to allow layout manipulation
as well.
AbstractHasData and subclasses (lots of cell widgets) is a nice abstract
class which already has most -- but not all -- methods declared in various
interfaces.
Unless we're waiting for a future patch to finish the job, I'm not yet
understanding the approach in which classes get selected for this treatment
and which types/methods get a pass. I don't mean for this to stand in the
way of this patch, but to suggest that the strategy is sufficiently unclear
that we could probably use a gwt-site doc on this or a body of javadoc that
covers how these are intended to be used, and how widget
authors/maintainers should behave to make their code usable by downstream
users who like these interfaces for testing.
--
To view, visit https://gwt-review.googlesource.com/3231
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd17162d37e367720829bcdaf9a350e446c833b9
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman <stephen.haber...@gmail.com>
Gerrit-Reviewer: Colin Alworth <niloc...@gmail.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Stephen Haberman <stephen.haber...@gmail.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
