On Wednesday, April 4, 2018 at 7:17:18 PM UTC+3, Roberto Lublinerman wrote:
>
> In any case, I don't expect the compiler changes to be significant. There
> are no new abstraction to be introduced nor structural changes. Could you
> start adding tests to GwtAstBuilderTest for these cases, even if they have
> to be disabled or commented out.
>
Yes, all i had to do to make non-denotable type to work, is to replace
`$Local$` type with anonymous synthetic class name `Outer$1` when creating
JClassType for JLocal.
Regarding tests - are you sure that GwtAstBuilderTest is a sutable place
for these tests? I noticed that Java9 tests were placed into the new
class Java9AstTest.
>
> BTW, which assertion is failing, is it one in JProgram.createLocal?
>
No, it is UnifyAst:
Compiling module sample.Java10
[ERROR] Could not find $Local$ in types compiled from source. Is the
source glob too strict?
[ERROR] An internal compiler exception occurred
com.google.gwt.dev.jjs.InternalCompilerException: Unexpected error during
visit.
at com.google.gwt.dev.jjs.ast.JVisitor.translateException(JVisitor.java:111
)
at com.google.gwt.dev.jjs.ast.JModVisitor.acceptImmutable(JModVisitor.java:
313)
at com.google.gwt.dev.jjs.ast.JMethodBody.traverse(JMethodBody.java:82)
at com.google.gwt.dev.jjs.ast.JModVisitor.traverse(JModVisitor.java:361)
at com.google.gwt.dev.jjs.ast.JModVisitor.accept(JModVisitor.java:273)
at com.google.gwt.dev.jjs.ast.JModVisitor.accept(JModVisitor.java:265)
at com.google.gwt.dev.jjs.ast.JMethod.visitChildren(JMethod.java:786)
at com.google.gwt.dev.jjs.ast.JMethod.traverse(JMethod.java:778)
at com.google.gwt.dev.jjs.ast.JModVisitor.traverse(JModVisitor.java:361)
at com.google.gwt.dev.jjs.ast.JModVisitor.accept(JModVisitor.java:273)
at com.google.gwt.dev.jjs.ast.JModVisitor.accept(JModVisitor.java:265)
at com.google.gwt.dev.jjs.impl.UnifyAst.mainLoop(UnifyAst.java:1401)
at com.google.gwt.dev.jjs.impl.UnifyAst.exec(UnifyAst.java:896)
at com.google.gwt.dev.jjs.JavaToJavaScriptCompiler.unifyJavaAst(
JavaToJavaScriptCompiler.java:1410)
at com.google.gwt.dev.jjs.JavaToJavaScriptCompiler.constructJavaAst(
JavaToJavaScriptCompiler.java:1222)
at com.google.gwt.dev.jjs.JavaToJavaScriptCompiler.precompile(
JavaToJavaScriptCompiler.java:1140)
at com.google.gwt.dev.jjs.JavaToJavaScriptCompiler.precompile(
JavaToJavaScriptCompiler.java:255)
at com.google.gwt.dev.Precompile.precompile(Precompile.java:255)
at com.google.gwt.dev.Precompile.precompile(Precompile.java:202)
at com.google.gwt.dev.Precompile.precompile(Precompile.java:143)
at com.google.gwt.dev.Compiler.compile(Compiler.java:204)
at com.google.gwt.dev.Compiler.compile(Compiler.java:155)
at com.google.gwt.dev.Compiler.compile(Compiler.java:144)
at com.google.gwt.dev.Compiler$1.run(Compiler.java:118)
at com.google.gwt.dev.CompileTaskRunner.doRun(CompileTaskRunner.java:55)
at com.google.gwt.dev.CompileTaskRunner.runWithAppropriateLogger(
CompileTaskRunner.java:50)
at com.google.gwt.dev.Compiler.main(Compiler.java:125)
Caused by: java.lang.AssertionError
at com.google.gwt.dev.jjs.impl.UnifyAst.translate(UnifyAst.java:1577)
at com.google.gwt.dev.jjs.impl.UnifyAst.translate(UnifyAst.java:1590)
at com.google.gwt.dev.jjs.impl.UnifyAst.access$1(UnifyAst.java:1586)
at com.google.gwt.dev.jjs.impl.UnifyAst$UnifyVisitor.endVisit(UnifyAst.java
:371)
at com.google.gwt.dev.jjs.ast.JVisitor.endVisit(JVisitor.java:328)
at com.google.gwt.dev.jjs.ast.JLocal.traverse(JLocal.java:55)
at com.google.gwt.dev.jjs.ast.JModVisitor.traverse(JModVisitor.java:361)
at com.google.gwt.dev.jjs.ast.JModVisitor.acceptImmutable(JModVisitor.java:
305)
... 25 more
[ERROR] at Java10Sample.java(14): $Local$ o
com.google.gwt.dev.jjs.ast.JLocal
[ERROR] at Java10Sample.java(13): <source info not available>
com.google.gwt.dev.jjs.ast.JMethodBody
[ERROR] at Java10Sample.java(13): sample.Java10Sample.onModuleLoad()V
com.google.gwt.dev.jjs.ast.JMethod
--
You received this message because you are subscribed to the Google Groups "GWT
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/google-web-toolkit-contributors/af18e910-9a3a-4337-9521-4538ce724f99%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
