#711: External Validation for Acute Kidney Injury(AKI) Predictive Models using
PCORnet CDM data
--------------------------+--------------------
Reporter: meiliu | Owner: xsong
Type: task | Status: new
Priority: major | Milestone:
Component: data-sharing | Resolution:
Keywords: aki cdm | Blocked By:
Blocking: |
--------------------------+--------------------
Comment (by dconnolly):
Replying to [comment:7 xsong]:
> received feedback from UIOWA about code testing and made the following
fixes (updated 09/13/2018)
> {{{
> util.R
> 1. use RJDBC instead of odbc
> --merged the change
> (line: 24-32, connect_to_db())
>
> ...
> }}}
>
> ... more detailed change log
That log of changes is particularly handy to have in the git history.
The
[https://github.com/sxinger/AKI_CDM/commit/6940fe78adf55dbe7a46708304335a1dda0242c6
6940fe7 commit message] says "... based on UIOWA's feedback" but it's not
clear without more context what that feedback is.
Note: references to tickets from code are OK, but only in a
supplementary role; they should not be essential to understanding the
purpose or design of the code. --
https://informatics.kumc.edu/work/wiki/CodeReviewNotes#CommunityPeerPerspective
--
Ticket URL:
<http://informatics.gpcnetwork.org/trac/Project/ticket/711#comment:9>
gpc-informatics <http://informatics.gpcnetwork.org/>
Greater Plains Network - Informatics
_______________________________________________
Gpc-dev mailing list
Gpc-dev@listserv.kumc.edu
http://listserv.kumc.edu/mailman/listinfo/gpc-dev
