On So, 2003-12-21 at 16:44, Emile le Vivre wrote: > Hi, > > I can include the feedback suggestions (expanded on below) and also make > the same changes to the GTK1 interface. However, I'm a bit confused as > to whether richard is working on this already or not.
You could say I'm in the process of applying your patch... but as I will say below I don't normally apply patches glade directly. > Are my patches in > an okay format? Actually I only looked at the screenshots at first and liked the changes and saw that doing them was something which I could do in little time. I look at the patch now: main_gui.c: I don't understand what the changes in main_gui.c do. It seems that you change the navi-tree menu... but what exactly do you change? setting_gui.c: I like your coding style here. I think the widgets_to_hide should better go to the expert_mode_changed function (where I put them locally). As for the bw settings: instead of coupling them to a "simplyfied gui" toggle, I would suggest to change the default visibility to "off" and leave it to the user to turn in on via the menu bar. How about that? Maybe we could couple the visibility of "leaf traffic" to being in UP mode? Would that be good to do? Note this: I don't reject that patch, but patches to glade and (btw.) the properties files I mostly apply by hand, using a text editor for the properties and glade for the gui stuff. The generated files (by glade or by the props) are of little interest to me. > ie. if you wanted to keep all of my changes, you > shouldn't have to open glade at all, right? I seldomly applied glade patches directly. Most of the time I redo them since reading a glade-file patch is not one of my favourites. C code patches are ok though. But I normally read those too first. > If it's ok, tonight (sun) or tomorrow I will make the following updates > to my changes (and any others we agree on) and bring the GTK1 interface > up to the same point as well. > > - Rearrange/rename the "add search" and "passive search" buttons > - Remove the "tabbed" mode for viewing search results > > - ?Possibly? combining my changes with the "expert mode" setting already > in place Doing the changes for expert mode are really really simple since it's just a matter of adding a few widget names to a function in settings_gui.c (around line 3663: expert_mode_changed(...)). I did that too locally. > I agree, this would work way cleaner. The only problem I see is that > people who want to fiddle with the more advanced settings don't > necessarily want all that extra stuff in the interface. Having only one > option means that if they want an simpler interface, they also don't > have access to the advanced options. Sure, they could turn on "expert > mode" adjust the settings and then turn it off again, but is that what > we want? I guess people who need the advanced settings will just leave it turned on. > The way it is now (well, with my patch) "Simplified user > interface" only hides widgets, it doesn't actually hide any settings. > I'm pretty sure the "allow experimenting with low-level settings" thingy > only hides settings, ie. it doesn't actually change the day-to-day > interface. So the two different options actually cover different areas > namely "Settings" and "Interface". Settings, widgets... what't the difference. > But, maybe that's a needless distinction. > > > The "passive search" button is missing on the screenshots. > > I would to relabel the "new search" button to "Add" or "New" > > and put the "Add passive" or "New passive" beside it only visible > > in expert mode. Passive is only usable in Classic or Ultra mode > > anyway. > > The passive button does pop back up if you disable the "simplified user > interface mode". But I agree it could be better placed. Ideally I'd > like to get rid of the "new search" button altogther. People just press > enter anyway and it's confusing clutter. Of course that would make it > even more unclear what the passive search button does. I think the best > would be to change the "new search" to "Add" as suggested and put an > "Add passive" button underneath it as opposed to beside it. Look at http://www.candledark.org/screens/screen2.jpg http://www.candledark.org/screens/screen3.jpg What do you think? > I guess if the user is in "expert" mode anyway we can expect them not to > be too confused about it... Although, is the passive search feature > something we need? Passive searches are a really nice feature in Ultrapeer mode. > > Tabbed mode > > > > It is still possible to show the searches as tabs and not in the > > sidebar (right click on searches -> show tabs). I would suggest > > to remove that feature for good. I don't think anybody is using it > > anyway. > > Oops, I knew that was there somewhere but I forgot where the option was > to turn it on. I'm all for removing it. Well, it could stay, but then the "add new searches" stuff in the sidebar must not be hidden when it's turned on, otherwise it's not longer possible to add new searched then. -- Richard Eckart <[EMAIL PROTECTED]> ------------------------------------------------------- This SF.net email is sponsored by: IBM Linux Tutorials. Become an expert in LINUX or just sharpen your skills. Sign up for IBM's Free Linux Tutorials. Learn everything from the bash shell to sys admin. Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click _______________________________________________ Gtk-gnutella-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
