Hi, On Thu, 2004-02-19 at 19:26, Thomas Schuerger wrote: > > > Thanks Thomas. I'll handle it this WE. > > > > I was actually planning to have a look at it tonight. If that is ok ;)
Well, a little bit later then I actually planned. I am changing some of the code to fit the coding style guide better. Also make sure you don't go beyond the 80 chars margin. Also I noticed the use of assertion where they a) Don't work b) Make gtk-gnutella remotely crashable What I mean with a is: For example there is a pointer *p then in the code there is something like int x = p->something g_assert(p) as you understand, if p would have been NULL it would have allready crashed on p->something b) is expecting data from a connection and assert if the expected data is not correct. Only assert when we are sending data which we generated ourself. Never assert on received data! I'll include your files later tonight. Allthough I modified some of them a bit. I hope you can correct the asserts under point b. - Jeroen ------------------------------------------------------- SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now! http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click _______________________________________________ Gtk-gnutella-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
