> > Thanks for your comments!
> > 
> > As for a), you are completely right, I was a bit careless there. Thanks
> > for fixing this.
> 
> Nevertheless assertion are good, but they should be used the right way.
> I will probably adjust the code even more to make sure those assertions
> can be used.

OK.

> Well a quick test indicated that there is a problem then with HSEP,
> because when I tell it to just pretend every connection to be HSEP
> enabled it _wil_ assert. I don't have time to look more thoroughly at it
> the comming days. If you want I can do a full commit, which only enabled
> HSEP for HSEP enabled clients. But this means CVS has to be updated soon
> again with an update.
> So I leave it up to you? You want me to commit the intergration
> completely? 

Please tell me what you did for testing. Does pretending every
connection to be HSEP-enabled mean you call setting the HSEP attribute
and calling hsep_connection_init() on each connection first?

Perhaps you could put the handshaking HSEP feature announcement and
setting the CAN_HSEP attribute into an "#ifdef USE_HSEP" section or
something, so that the code can be committed but is normally disabled.
Then I'll do the testing ASAP. Later the #ifdef can then be removed
again (no need to make this a real compile-time option like remote
shell etc.).


Greetings,
Thomas.



-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
Gtk-gnutella-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel

Reply via email to