I have to say the iter stuff seemed a little hacky (faking a glist entry to before a real one). Why don't we iterate through the glists the normal glib way?
I don't know why there is an extra layer over the glist. But I
personally do find it easier/better to read.
Allthough a while(move_iter_next(iter)) { } would be someting I like
even more. But that is just personal.
Is this related to the liberal use of break; and continue; in the download_pickup_queued(void) function? After instrumenting it I was going to refsactor that inner-loop into a new function and do away with the iter stuff. Also I'm not convinced about the retry logic. Is it really so bad to wait until the next timer expires to re-parse the queues?
Re-parse in what way? The Waiting queue is allready read on every timer event. - Jeroen ps. There is no need to CC me in, I am subscribed to the list.
smime.p7s
Description: S/MIME Cryptographic Signature
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ Gtk-gnutella-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
