On Wed, August 23, 2006 12:06, Jeroen Asselman said:
>
>> I have to say the iter stuff seemed a little hacky (faking a glist entry
>> to before a real one). Why don't we iterate through the glists the
>> normal
>> glib way?
>
> I don't know why there is an extra layer over the glist. But I
> personally do find it easier/better to read.
> Allthough a while(move_iter_next(iter)) { } would be someting I like
> even more. But that is just personal.

I may give it a try. I maxed at 250Kb/s on multiple downloads this morning
- but I'm still not convinced all the downloads that should of been tried
did get tried.

>
<s,ip>
>>
>> Also I'm not convinced about the retry logic. Is it really so bad to
>> wait
>> until the next timer expires to re-parse the queues?
>>
> Re-parse in what way? The Waiting queue is allready read on every timer
> event.

I was refering to the goto retry logic. It seems a bit pointless, even if
the timers have changed the whole queue is re-read on the next timer
event.

> - Jeroen
> ps. There is no need to CC me in, I am subscribed to the list.

Sorry - force of habit. Reply All ensures you always get through whoever
your responding to.

-- 
Alex
http://www.bennee.com/~alex/


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Gtk-gnutella-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel

Reply via email to