Hi, On 2026-04-27 at 16:38+02:00, Gabriel Wicki wrote: > Ludovic Courtès writes: > > Andreas Enge skribis: > > > With opt-in, my fear is that we will never finish, > > > > With opt-out, my fear is that we will never start :-) because we're > > talking about several thousand packages that will need to be checked > > manually. > > Starting this is not much more than introducing errors (and the relevant > messages) in the substitute* function, pushing these changes to a > branch, asking QA to start building and investigating, no?
I support this course of action. On 2026-04-27 at 15:27-04:00, Jason Conroy wrote: > - 8643 total pattern matches > > Based on the above, I agree that opt-out is a non-starter without > some plan for incremental migration. Thanks for the statistics, and I think the number of bad calls is a couple orders smaller than the total. On 2026-04-27 at 15:27-04:00, Jason Conroy wrote: > 1) One module at a time, rebind substitute* to substitute**, > rebuild, and fix errors. For the files with hundreds of matches, > maybe place the rebinding closer to the bottom of the file to > limit its scope, then move it toward the top over successive PRs. IIUC this entails modify (and rebuild) each package using it to opt in. It does not seem economical given most calls requires no modification. On 2026-04-27 at 17:30+02:00, Hugo Buddelmeijer wrote: > On 27/4/26 16:38, Gabriel Wicki wrote: > > But to be a bit more on the issue: if a substitute* call fails for > > either not finding a file or not being able to match the regex, the > > solution is to delete that call. > > The solution would be to investigate whether the now-failing > substitution is still necessary or not; that investigation is not > necessarily quick and easy. Agreed, though we are talking about fixing probably about 100 packages here. This is a lot fewer than the recent pyproject migration (1738 packages, opt-in), which took its course over 9 months. Best wishes, Phong
signature.asc
Description: PGP signature
