On Tue, Dec 08, 2015 at 10:31:31PM +0100, Markus Teich wrote: > FRIGN wrote: > > Dimitris Papastamos <s...@2f30.org> wrote: > > > This also works with jpg and gif and others. The 2ff wrapper will use > > > imagemagick conversion tools. This is temporary as jpg2ff and gif2ff will > > > also be implemented. > > > > As a side note, the 2ff-filter can also receive png-images and already > > automatically call png2ff when it detects a png. If you look at the 2ff > > script, you'll notice how simple it is really. > > Heyho, > > as you guys can see from the push hook mails, I just merged the second > farbfeld > patch from Dimitris. Since case-switching in sent (the filters array) and in > 2ff > again seems kind of redundant, I would remove the filter array and regex code > again and just call filter() on the 2ff script. Of course this only works, if > 2ff does not go „full pipeline“ and continues to support handling one > argument.
I would be inclined to keep regex matching. 2ff is a helper. One can imagine piping gnuplot files to generate graphs. > Another change I want to make is combining the open and read function. Then we > would know if every image could be loaded correctly before even starting the > presentation, which prevents erroring out right in the middle of your talk, > when > some image could not be loaded from advance(). Yes makes sense.
