[
https://issues.apache.org/jira/browse/HADOOP-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496671
]
Doug Cutting commented on HADOOP-1298:
--------------------------------------
This is mostly looking good to me. We really need some input from Dhruba
and/or Konstantin.
1. Seven methods are replicated between PosixConstants and Permissions. These
should be shared. Why not rename PosixConstants to be Permissions, add these
seven methods, then have DFSPermissions subclass it, adding uid and gid fields
& other methods?
2. The FileSystem methods which accept 'short permissions' should reference
PosixConstants (or wherever the bits are defined).
3. By "complete sentences" I mean starting with a capital and ending with a
period. You should run 'ant javadoc' before submitting your patch and make
sure that (a) no documentation boxes in code you've added are empty; (b) no
warnings are generated; and (c) that your javadoc resembles other javadoc.
> adding user info to file
> ------------------------
>
> Key: HADOOP-1298
> URL: https://issues.apache.org/jira/browse/HADOOP-1298
> Project: Hadoop
> Issue Type: New Feature
> Components: dfs, fs
> Reporter: Kurtis Heimerl
> Attachments: hadoop-user-munncha.patch, hadoop-user-munncha.patch,
> hadoop-user-munncha.patch, hadoop-user-munncha.patch10,
> hadoop-user-munncha.patch11, hadoop-user-munncha.patch12,
> hadoop-user-munncha.patch13, hadoop-user-munncha.patch14,
> hadoop-user-munncha.patch15, hadoop-user-munncha.patch4,
> hadoop-user-munncha.patch5, hadoop-user-munncha.patch6,
> hadoop-user-munncha.patch7, hadoop-user-munncha.patch8,
> hadoop-user-munncha.patch9
>
>
> I'm working on adding a permissions model to hadoop's DFS. The first step is
> this change, which associates user info with files. Following this I'll
> assoicate permissions info, then block methods based on that user info, then
> authorization of the user info.
> So, right now i've implemented adding user info to files. I'm looking for
> feedback before I clean this up and make it offical.
> I wasn't sure what release, i'm working off trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
