[
https://issues.apache.org/jira/browse/HADOOP-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498814
]
Raghu Angadi commented on HADOOP-1425:
--------------------------------------
Its not just about number of lines.. My main complaint is same as Owen's: in
the current form, ToolBase is not a good abstraction.
I am not really asking for getting rid of ToolBase, if it suits well in some
cases, users can use it. Its just not obvious to me. When I first saw
{{doMain()}} I wondered why I need to implement {{run()}} and invoke it so
indirectly.
All I am recommending is to make parseGeneralOptions() public.
> Rework the various programs in 'examples' to extend ToolBase
> -------------------------------------------------------------
>
> Key: HADOOP-1425
> URL: https://issues.apache.org/jira/browse/HADOOP-1425
> Project: Hadoop
> Issue Type: Improvement
> Components: examples
> Reporter: Arun C Murthy
> Assigned To: Enis Soztutar
> Priority: Minor
> Fix For: 0.14.0
>
>
> Ensuring all 'examples' extend ToolBase will make it easy to tweak various
> config params (via -D switches for e.g.) while running the programs...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
