Hi Willy,
Le 16/12/2019 à 22:06, Artur a écrit :
[...]
URLs like https://q.d/PPDSlide/testfile are correctly rewritten to
https://q.d/p3/PPDSlide/testfile and forwarded to the backend.
Once I switched to 2.1.1, haproxy no longer rewrites the URI and the
URIs remains unchanged while forwarded to the backend. I had to
downgrade to have the usual behaviour.
Is it a bug or something changed in normal haproxy behaviour with 2.1
release ?
I can confirm the issue.
It seems to happen with h2 requests only, since commit #30ee1efe67.
haproxy normalizes the URI but replace-uri doesn't take into account
this information. The fix should be easy for replace-uri (If someone
wants to work on it, I won't have time this week).
http://git.haproxy.org/?p=haproxy-2.1.git;a=commit;h=30ee1efe67
I'm not 100% sure it's the right approach to fix the issue. Can you
check if this patch may fix the issue in all conditions ?
From what I've observed, it seems we can rely on the
HTX_SL_F_NORMALIZED_URI flag to detect if the URI was normalized by
haproxy and in that case, we should start at the path instead of the URI.
--
Cyril Bonté
diff --git a/src/http_act.c b/src/http_act.c
index d6015d362..797d75275 100644
--- a/src/http_act.c
+++ b/src/http_act.c
@@ -141,6 +141,7 @@ static enum act_return http_action_replace_uri(struct act_rule *rule, struct pro
{
enum act_return ret = ACT_RET_ERR;
struct buffer *replace, *output;
+ struct htx_sl *sl;
struct ist uri;
int len;
@@ -148,7 +149,12 @@ static enum act_return http_action_replace_uri(struct act_rule *rule, struct pro
output = alloc_trash_chunk();
if (!replace || !output)
goto leave;
- uri = htx_sl_req_uri(http_get_stline(htxbuf(&s->req.buf)));
+
+ sl = http_get_stline(htxbuf(&s->req.buf));
+ uri = htx_sl_req_uri(sl);
+ if (sl->flags & HTX_SL_F_NORMALIZED_URI)
+ uri = http_get_path(uri);
+
if (!regex_exec_match2(rule->arg.act.p[1], uri.ptr, uri.len, MAX_MATCH, pmatch, 0))
goto leave;
