2006/4/21, Anton Avtamonov <[EMAIL PROTECTED]>: > On 4/21/06, Tim Ellison <[EMAIL PROTECTED]> wrote: > > > > Mikhail Loenko wrote: > > > 2006/4/21, Tim Ellison <[EMAIL PROTECTED]>: > > >> Mikhail Loenko wrote: > > >>> Well, the reason is we did not discuss the topic here > > >> Sure. What would you like to discuss? > > > > > > 1. Do we put all the messages into one file or per-module? > > > > I'd prefer one catalog per module now that we have the code split up. > > The risk is that there will be large duplication of common messages, but > > let's see, they should stand alone. > > Definitely. I think that keeping them serarately increases modularization. > > > If we do split them up then I guess it makes sense to put the accessor > > class and properties files into org.apache.harmony.<component>.internal? > > +1 > > > Creating and maintaining these (accessor/strings) is trivial in the > > Eclipse string externalization tool. > > Right. > > > > > > 2. When I tried to internationalize it with Eclipse it suggested me > > > keys looking > > > different way (something like "RandomAccessFile.1"). So what are the keys > > > that > > > are liked by most of the people? > > > > I'd prefer the module name '.', i.e. beans.1, beans.2, and so on. > > I'm not sure. Module name IMHO doesn't make too much sense since it is > already 'coded' into accessor location and class location. I would > prefer <class_name>.<message intention> like > RandomAccessFile.file_is_closed > or something similar which keeps the idea of what the message is about.
That would create more duplication like File.file_is_closed RandomAccessFile.file_is_closed ... Thanks, Mikhail > > That requires a bit more efforts but makes the code understandable. > > > Wishes, > -- > Anton Avtamonov, > Intel Middleware Products Division > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]