On 9/28/06, Gregory Shimansky <[EMAIL PROTECTED]> wrote:
On Wednesday 27 September 2006 14:20 Egor Pasko wrote:
> On the 0x1F1 day of Apache Harmony Xiao-Feng Li wrote:
> > Thanks. Yes, this is supposed to be review by JIT person. On the other
> > hand, if JIT person has better solution, GCv5 would like to use.
> > Anyway we hope write barrier is to be functioning in the DRLVM soon.
>
> As a JIT-oriented guy, I looked through the patch. Looks good. The
> write barrier does NOT push an M2N frame before invoking
> gc_heap_slot_write_ref(), but it's OK since there will be no stack
> unwinding from here.
I want to make sure that there are going to be no JVMTI events sent inside of
gc_heap_slot_write_ref. Otherwise M2N frame is necessary to allow stack
iterator to work in case a JVMTI agent calls something like GetStackTrace.
No, stack should never be examined in write barrier. That's completely
contridicting the purpose of write barrier.
Thanks,
xiaofeng
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]