Pardon for my English - a bit sleepy already... 2006/11/15, Alexey Varlamov <[EMAIL PROTECTED]>:
Err, what I found is really trivial bug. But it took quite a few time to discover - seems today was not my day :(Index: vm/vmcore/src/exception/exceptions_impl.cpp =============================================================== --- vm/vmcore/src/exception/exceptions_impl.cpp (revision 475132) +++ vm/vmcore/src/exception/exceptions_impl.cpp (working copy) @@ -281,7 +281,7 @@ if (NULL != exception->exc_cause) { tmn_suspend_disable_recursive(); - jthrowable exc_cause = oh_allocate_local_handle(); + exc_cause = oh_allocate_local_handle(); exc_cause->object = exception->exc_cause; tmn_suspend_enable_recursive(); } OK, we definitely need a regression test for this. 2006/11/15, Gregory Shimansky <[EMAIL PROTECTED]>: > Alexey Varlamov wrote: > > 2006/11/15, Alexey Varlamov <[EMAIL PROTECTED]>: > >> 2006/11/15, Gregory Shimansky <[EMAIL PROTECTED]>: > >> > Alexey Varlamov wrote: > >> > > The guilty change is the following, which effectively turns on > >> > > VM_LAZY_EXCEPTION support in exceptions_impl.cpp: > >> > > >> > Well this is a patch from HARMONY-2018 which doesn't hide the fact that > >> > it enables lazy exceptions. Why shouldn't we enable them? > > > > Gregory, > > > > I've just re-read my posts and couldn't find anything critique or > > offending - please don't take regressions too personal. I'm sure we > > will be able to fix this one quite soon. > > I wasn't offended in any way. I was just thinking that you know some > secret knowledge that lazy exceptions do not work and thus enabling them > is wrong. > > -- > Gregory > >
