As Gregory mentioned ThreadTest.testJoinlongint() failure he observed yesterday, I filed a http://issues.apache.org/jira/browse/HARMONY-2204 issue for that. I saw this failure quite long ago but cannot reproduce it today trying different platforms/EMs. When the test failed, it reported that actual wait time is less than required.
The spec for join() reads: "Waits at most millis milliseconds plus nanosnanoseconds for this thread to die. " There is an obvious misprint here: there should be "at least" but not "at most" and this was mentioned in http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4132653 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5068368 On the other hand, in classlib ThreadTest I saw that they agree with Thread.sleep(1000) duration >= 800 and join(100, 999999) duration <= 300. Can the current DRLVM guarantee that it does not exit join() earlier than expected? If not, we should make the test more tolerable to timing. On 11/16/06, Elena Semukhina <[EMAIL PROTECTED]> wrote:
Thank you, Gregory! On 11/15/06, Gregory Shimansky <[EMAIL PROTECTED]> wrote: > > Elena Semukhina wrote: > > I've found one more issue in the kernel ThreadTest. Filed > > https://issues.apache.org/jira/browse/HARMONY-2193. > > > > Alexey, please take a look! > > I am not an Alexey, but I assigned this JIRA to myself. The testcase > seems to be working both on linux and windows, I committed the patch. > > > On 11/14/06, Alexey Varlamov <[EMAIL PROTECTED]> wrote: > >> > >> 2006/11/14, Gregory Shimansky < [EMAIL PROTECTED]>: > >> > On Monday 13 November 2006 15:51 Elena Semukhina wrote: > >> > > On 10/26/06, Elena Semukhina <[EMAIL PROTECTED] > wrote: > >> > > > After H-1823 has been committed, I still see intermittent > failures > >> of > >> > > > drlvm kernel ThreadTest. Normally this test passes but today I > got > >> > > > ThreadTest.testInterrupt_Sleeping() and testGetStateBlocked() > >> failures. > >> > > > There is H-1789 for the first issue but it is not reprodiced > with > >> the > >> > > > attached test anymore. For the second test I filed H-1876 to > make > >> the > >> > > > test more stable. The patch has been committed recently but the > >> test > >> > > > still may fail. I'd like someone to review the above mentioned > >> tests > >> to > >> > > > be sure they are correct otherwise we need to investigate > failures > >> and > >> > > > file JIRA's before the tests are exclued. > >> > > > >> > > I looked at ThreadTest again and found one more incorrectness in > >> > > testGetStateBlocked(): it does not wait for the thread's run() > method > >> > > actually starts. I filed > >> https://issues.apache.org/jira/browse/HARMONY-2166 > >> > > and attached the patch. I ran the test more than 100 times and > did > >> not > >> see > >> > > a failure. > >> > > >> > Cool! I'd like to see this patch applied (in case it really helps) > >> ASAP. > >> > Alexey V, please don't hold it for long. I would really like to see > all > >> > acceptance to pass again on all platforms and then we'll maintain > no > >> > regression state. > >> > >> Verified and applied (at r474672). BTW, seems we are very close to > >> 100% pass rate for classlib tests on DRLVM. The wiki status page [1] > >> lists just few pending issues, hopefully we'll fix them all in a > >> couple of days. > >> > >> [1] http://wiki.apache.org/harmony/Unit_Tests_Pass_on_DRLVM > >> > > > > > > > > > -- > Gregory > > -- Thanks, Elena
-- Thanks, Elena
