----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6114/ -----------------------------------------------------------
(Updated July 31, 2012, 6:45 p.m.) Review request for hcatalog and Rohini Palaniswamy. Changes ------- Summary of change: 1. Made the cache ThreadLocal 2. Catching Exception in shutdown hook and teardown() 3. Still using configuration to enable/disable the cache All the other comments have been incorporated. For item 2. I see that most of the online resources point towards catching *Exception* only instead of Throwable and thus Error. As Error means some low level error with JVM in which case probably there is no point for us to proceed and try to close other clients. Interesting discussion: http://stackoverflow.com/questions/581878/why-catch-exceptions-in-java-when-you-can-catch-throwables For item 3. I am more inclined towards keeping the configuration but should definitely remove it in the next minor release itself. Description ------- Time expiry based HiveMetaStoreClient cache for HCatalog This addresses bug HCATALOG-370. https://issues.apache.org/jira/browse/HCATALOG-370 Diffs (updated) ----- http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/ivy.xml 1364830 http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/common/HCatConf.java PRE-CREATION http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/common/HCatConstants.java 1364830 http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/common/HCatUtil.java 1364830 http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/common/cache/HiveClientCache.java PRE-CREATION http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java 1364830 http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java 1364830 http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java 1364830 http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java 1364830 http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java 1364830 http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/pig/PigHCatUtil.java 1364830 http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/test/org/apache/hcatalog/common/TestHiveClientCache.java PRE-CREATION Diff: https://reviews.apache.org/r/6114/diff/ Testing ------- Thanks, Arup Malakar
