----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6114/ -----------------------------------------------------------
(Updated Aug. 14, 2012, 12:24 a.m.)
Review request for hcatalog and Rohini Palaniswamy.
Changes
-------
The webhcat test cases donot work with the cache. The reason being if the
HiveMetaStoreClient is used to create a table with a very long name it cannot
be reused again.
Fixes are:
1. Added a health check in the get() of HiveClientCache to invalidate a client
which is not usable
2. Added the relevant jars in webhcat (it was failing complaining that it
couldn't find guava jar)
3. Modified TestHCatClient in the process to create the server only once
instead of creating per unit test
Description
-------
Time expiry based HiveMetaStoreClient cache for HCatalog
This addresses bug HCATALOG-370.
https://issues.apache.org/jira/browse/HCATALOG-370
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/ivy.xml
1372522
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/ivy/libraries.properties
1372522
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/common/HCatConstants.java
1372522
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/common/HCatUtil.java
1372522
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/common/HiveClientCache.java
PRE-CREATION
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
1372522
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
1372522
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java
1372522
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
1372522
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
1372522
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/pig/PigHCatUtil.java
1372522
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/test/org/apache/hcatalog/common/TestHiveClientCache.java
PRE-CREATION
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/webhcat/java-client/build.xml
1372522
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/webhcat/java-client/src/main/java/org/apache/hcatalog/api/HCatClientHMSImpl.java
1372522
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/webhcat/java-client/src/test/java/org/apache/hcatalog/api/TestHCatClient.java
1372522
Diff: https://reviews.apache.org/r/6114/diff/
Testing
-------
Thanks,
Arup Malakar
