----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6114/ -----------------------------------------------------------
(Updated Aug. 3, 2012, 1:11 a.m.)
Review request for hcatalog and Rohini Palaniswamy.
Changes
-------
Change summary:
1. use HCAT prefix
2. made the cache class package private after moving it to common
3. Only one cache instance and it uses unique thread id as one of the elements
in the cache key
4. Shutdown moved to a new method
5. Brought back threadsafety
6. Removed the configuration to disable the cache
7. Test case for multithreaded access and closeClients
Description
-------
Time expiry based HiveMetaStoreClient cache for HCatalog
This addresses bug HCATALOG-370.
https://issues.apache.org/jira/browse/HCATALOG-370
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/ivy.xml
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/common/HCatConstants.java
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/common/HCatUtil.java
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/common/HiveClientCache.java
PRE-CREATION
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/pig/PigHCatUtil.java
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/test/org/apache/hcatalog/common/TestHiveClientCache.java
PRE-CREATION
Diff: https://reviews.apache.org/r/6114/diff/
Testing
-------
Thanks,
Arup Malakar
