[ https://issues.apache.org/jira/browse/HDFS-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865899#action_12865899 ]
Bharath Mundlapudi commented on HDFS-1061: ------------------------------------------ Thanks for the review, Jakob. Some thoughts on your comments: 1. Yes, Zero replica seems odd but didn't want to break the old semantics since earlier versions was allowing 0 and < 0 values. Atleast its clear NOT accept < 0 values. 2. The reason i put always-fail assert because the test-case always throws an exception. Let me know if you want me to add/change something. > Memory footprint optimization for INodeFile object. > ---------------------------------------------------- > > Key: HDFS-1061 > URL: https://issues.apache.org/jira/browse/HDFS-1061 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node > Affects Versions: 0.22.0 > Reporter: Bharath Mundlapudi > Assignee: Bharath Mundlapudi > Priority: Minor > Fix For: 0.22.0 > > Attachments: HDFS-1061-1.patch, HDFS-1061-2.patch, HDFS-1061.patch > > > I am proposing a footprint optimization to merge blockReplication and > preferredBlockSize fields into one 'long header' field in INodeFile class. > This saves 8 bytes per INodeFile object on a 64 bit JVM. This memory > optimization is transparent and changes are very minimal. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.