[
https://issues.apache.org/jira/browse/HDFS-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034388#comment-13034388
]
Tsz Wo (Nicholas), SZE commented on HDFS-1573:
----------------------------------------------
> ... If you're strongly against it, happy to remove.
Since {{@VisibleForTesting}} is not yet used in our test framework, I think it
is rather confusing to use it here. Please remove it. We could add such
annotations when we are actually using them.
- For the {{getDaemon()}} method, how about change it to {{getDaemonName()}}
which returns a string?
- For {{instantiationTrace}}, it is better to create it using {{new
Throwable("TRACE")}} and store it as a string.
> LeaseChecker thread name trace not that useful
> ----------------------------------------------
>
> Key: HDFS-1573
> URL: https://issues.apache.org/jira/browse/HDFS-1573
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: hdfs-1573.txt, hdfs-1573.txt
>
>
> The LeaseChecker thread in DFSClient will put a stack trace in its thread
> name, theoretically to help debug cases where these threads get leaked.
> However it just shows the stack trace of whoever is asking for the thread's
> name, not the stack trace of when the thread was allocated. I'd like to fix
> this so that you can see where the thread got started, which was presumably
> its original intent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
