[
https://issues.apache.org/jira/browse/HDFS-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037102#comment-13037102
]
Todd Lipcon commented on HDFS-1936:
-----------------------------------
I think this looks good. Here are two comments:
- not sure I follow this - this is just a fix of an incorrect check in a
previous version?
{code}
private void loadSecretManagerState(DataInputStream in) throws IOException
{
- if (imgVersion > -23) {
+ if (imgVersion > -24) {
//SecretManagerState is not available.
//This must not happen if security is turned on.
{code}
- why this change?
{code}
* OctalPerms (short -> String) // Modified in -19
- * Symlink (String) // added in -23
+ * Symlink (String)
* NumINodesUnderConstruction (int)
{code}
The PRE_RBW_LAYOUT_VERSION is a good point. I didn't actually notice that but
it looks like you're right that it's not a correct check since it misses the
20x branches.
> Updating the layout version from HDFS-1822 causes upgrade problems.
> -------------------------------------------------------------------
>
> Key: HDFS-1936
> URL: https://issues.apache.org/jira/browse/HDFS-1936
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Blocker
> Fix For: 0.22.0, 0.23.0
>
> Attachments: HDFS-1936.22.patch, HDFS-1936.trunk.patch
>
>
> In HDFS-1822 and HDFS-1842, the layout versions for 203, 204, 22 and trunk
> were changed. Some of the namenode logic that depends on layout version is
> broken because of this. Read the comment for more description.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
