[
https://issues.apache.org/jira/browse/HDFS-13610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521804#comment-16521804
]
Yiqun Lin commented on HDFS-13610:
----------------------------------
[~xkrogen], did the quick review for the v00 patch, some minor comments:
* As I see dfs.ha.tail-edits.qjm.rpc.max-txns is not public and not be
documented in hdfs-default.xml, seems we also need to remove this in doc.
* For the test case TestStandbyInProgressTail#testCorruptJournalCache, if I am
understanding correct, this is test In-Progress Tailing with skipping
JournalCache, and fallback to use the streaming way, right? So the name
testServeEditsSkippingCache maybe better understanding than
testCorruptJournalCache.
> [Edit Tail Fast Path Pt 4] Cleanup: integration test, documentation, remove
> unnecessary dummy sync
> --------------------------------------------------------------------------------------------------
>
> Key: HDFS-13610
> URL: https://issues.apache.org/jira/browse/HDFS-13610
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, journal-node, namenode
> Reporter: Erik Krogen
> Assignee: Erik Krogen
> Priority: Major
> Attachments: HDFS-13610-HDFS-12943.000.patch
>
>
> See HDFS-13150 for full design.
> This JIRA is targeted at cleanup tasks:
> * Add in integration testing. We can expand {{TestStandbyInProgressTail}}
> * Documentation in HDFSHighAvailabilityWithQJM
> * Remove the dummy sync added as part of HDFS-10519; it is unnecessary since
> now in-progress tailing does not rely as heavily on the JN committedTxnId
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
