[ https://issues.apache.org/jira/browse/HDFS-13610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526036#comment-16526036 ]
Yiqun Lin commented on HDFS-13610: ---------------------------------- Thanks for updating the patch, [~xkrogen]! Two comments from me: * For the {{TestStandbyInProgressTail#waitForFileInfo}}, I will prefer to pass a file name list and do the removal in {{GenericTestUtils.waitFor}} once getFileInfo returns value info. We don't need to request for all the files every time. * In the doc, can we mention the mainly use case of In-Progress Edit Log Tailing? I mean we can document Standby Read there. This is why we make SBN to have more up-to-date namespace info. > [Edit Tail Fast Path Pt 4] Cleanup: integration test, documentation, remove > unnecessary dummy sync > -------------------------------------------------------------------------------------------------- > > Key: HDFS-13610 > URL: https://issues.apache.org/jira/browse/HDFS-13610 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ha, journal-node, namenode > Reporter: Erik Krogen > Assignee: Erik Krogen > Priority: Major > Attachments: HDFS-13610-HDFS-12943.000.patch, > HDFS-13610-HDFS-12943.001.patch, HDFS-13610-HDFS-12943.002.patch > > > See HDFS-13150 for full design. > This JIRA is targeted at cleanup tasks: > * Add in integration testing. We can expand {{TestStandbyInProgressTail}} > * Documentation in HDFSHighAvailabilityWithQJM > * Remove the dummy sync added as part of HDFS-10519; it is unnecessary since > now in-progress tailing does not rely as heavily on the JN committedTxnId -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org