[ https://issues.apache.org/jira/browse/HDFS-13610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530191#comment-16530191 ]
Chao Sun commented on HDFS-13610: --------------------------------- Thanks [~xkrogen]! A few of comments (mostly nits): 1. In {{JournaledEditsCache}}, do we need the check: {{lowestTxnId < 0}}? seems the cache is already initialized in constructor. 2. nit: Can we define a static variable such as {{INVALID_LAYOUT_VERSION}} to store the {{Integer.MAX_VALUE}}? 3. nit: {{Journal.LOG.info(logMsg.toString());}}: the {{toString}} is not necessary? 4. Why we need {{getJournaledEditsCache()}} in {{JournalTestUtil}}? can we replace it with {{journal.getJournaledEditsCache();}}? 5. nit: Can we also update {{JournaledEditsCache}} to add an empty line between the Java doc and method parameters? 6. nit: in {{JournalTestUtil}}, maybe remove the extra empty line after {{package org.apache.hadoop.hdfs.qjournal.server;}}? > [Edit Tail Fast Path Pt 4] Cleanup: integration test, documentation, remove > unnecessary dummy sync > -------------------------------------------------------------------------------------------------- > > Key: HDFS-13610 > URL: https://issues.apache.org/jira/browse/HDFS-13610 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ha, journal-node, namenode > Reporter: Erik Krogen > Assignee: Erik Krogen > Priority: Major > Attachments: HDFS-13610-HDFS-12943.000.patch, > HDFS-13610-HDFS-12943.001.patch, HDFS-13610-HDFS-12943.002.patch, > HDFS-13610-HDFS-12943.003.patch > > > See HDFS-13150 for full design. > This JIRA is targeted at cleanup tasks: > * Add in integration testing. We can expand {{TestStandbyInProgressTail}} > * Documentation in HDFSHighAvailabilityWithQJM > * Remove the dummy sync added as part of HDFS-10519; it is unnecessary since > now in-progress tailing does not rely on the JN committedTxnId > A few bugs are also fixed: > * Due to changes in HDFS-13609 to enable use of the RPC mechanism whenever > inProgressOK is true, there were codepaths which would use the RPC mechanism > even when dfs.ha.tail-edits.in-progress was false, meaning that the JNs did > not enable the cache. Update the QJM logic to only use selectRpcInputStreams > if this config is true. > * Fix a false error logged when the layout version changes > * Fix the logging when a layout version change occurs to avoid printing out a > placeholder value (Integer.MAX_VALUE) -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org