[ 
https://issues.apache.org/jira/browse/HDDS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710480#comment-16710480
 ] 

Elek, Marton commented on HDDS-891:
-----------------------------------

Thanks the feedback [~aw].

Please note that the hadoop-ozone and hadoop-hdds in the current trunk doesn't 
depend on the in-tree hadoop-hdfs/common projects. It depends on the 
hadoop-3.2-SNAPSHOT as of now and we would like to switch to a stable release 
as soon as possible.

Therefore it's not possible to modify both hdds/ozone AND hadoop in the same 
patch. Technically it's possible, but ozone/hdds code won't see the new changes 
in hdfs/common projects as they are 3.3-SNAPSHOT.

We can add additional check that HDDS issues to ensure that the patches modify 
only the ozone/hdds subprojects and not the core hadoop/hdfs/common projects. 
With this modification I think it's safe to do a full ozone/hdds only build for 
hdds precommit hook. What do you think about it?

about b): I like the idea and I tried to implement it. Would you be so kind to 
review the v2 patch of YETUS-631?

> Create customized yetus personality for ozone
> ---------------------------------------------
>
>                 Key: HDDS-891
>                 URL: https://issues.apache.org/jira/browse/HDDS-891
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>
> Ozone pre commit builds (such as 
> https://builds.apache.org/job/PreCommit-HDDS-Build/) use the official hadoop 
> personality from the yetus personality.
> Yetus personalities are bash scripts which contain personalization for 
> specific builds.
> The hadoop personality tries to identify which project should be built and 
> use partial build to build only the required subprojects because the full 
> build is very time consuming.
> But in Ozone:
> 1.) The build + unit tests are very fast
> 2.) We don't need all the checks (for example the hadoop specific shading 
> test)
> 3.) We prefer to do a full build and full unit test for hadoop-ozone and 
> hadoop-hdds subrojects (for example the hadoop-ozone integration test always 
> should be executed as it contains many generic unit test)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to