[
https://issues.apache.org/jira/browse/HDDS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714317#comment-16714317
]
Allen Wittenauer commented on HDDS-891:
---------------------------------------
bq. YOr is the problem to check a modification which is filed under HADOOP but
modifies something under hadoop-ozone/hadoop-hdds? I don't think it it's
handled right now (so we are as good as now), and I didn't see any example for
that.
We've already been seeing this fail in the nightly qbt since ozone got
committed. Whether we see changes happening anywhere else or not is
irrelevant.
bq. Can't see any problem here. A full (hadoop + ozone) checkstyle should
execute exactly the same checkstyle rules which are checked by the ozone
personality.
It currently does not.
bq. For me using hadoop + ozone personalities seems to be a more clean
separation.
Ozone is part of Hadoop. The whole point of making it that was, from what I
can tell, to get co-bundled at some point in the future. Making a separate
personality is exactly the opposite direction and for reasons which have yet to
be justified as to why that is desirable.
My -1 remains.
> Create customized yetus personality for ozone
> ---------------------------------------------
>
> Key: HDDS-891
> URL: https://issues.apache.org/jira/browse/HDDS-891
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
>
> Ozone pre commit builds (such as
> https://builds.apache.org/job/PreCommit-HDDS-Build/) use the official hadoop
> personality from the yetus personality.
> Yetus personalities are bash scripts which contain personalization for
> specific builds.
> The hadoop personality tries to identify which project should be built and
> use partial build to build only the required subprojects because the full
> build is very time consuming.
> But in Ozone:
> 1.) The build + unit tests are very fast
> 2.) We don't need all the checks (for example the hadoop specific shading
> test)
> 3.) We prefer to do a full build and full unit test for hadoop-ozone and
> hadoop-hdds subrojects (for example the hadoop-ozone integration test always
> should be executed as it contains many generic unit test)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
