[
https://issues.apache.org/jira/browse/HDDS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714112#comment-16714112
]
Elek, Marton commented on HDDS-891:
-----------------------------------
bq. a) It's still possible to modify these components from the other JIRA
categories.
Yes, but for other jira categories other pre-commit build will be executed. We
can check the hdds/ozone changes with ozone personality and other changes
(HADOOP/HDDS/MAPREDUCE) can be checked with the hadoop personalities. I think
we agreed that we shouldn't mix the two kind of changes in one patch.
Or is the problem to check a modification which is filed under HADOOP but
modifies something under hadoop-ozone/hadoop-hdds? I don't think it it's
handled right now (so we are as good as now), and I didn't see any example for
that. Worst case we can also improve the hadoop personality to fail in case of
a hadoop-ozone/hadoop-hdds changes are included.
bq. b) This part of the project still needs the capability to modify other
modules (e.g., hadoop-dist)
Not sure. Ozone is packaged by hadoop-ozone/dist maven project and not
hadoop-dist project. If we need to modify something to modify outside the
hadoop-ozone/hadoop-hdds projects I propose to do this in a HADOOP jira which
are checked with the hadoop personality.
bq. c) qbt runs over the entire source repository
Can't see any problem here. A full (hadoop + ozone) checkstyle should execute
exactly the same checkstyle rules which are checked by the ozone personality.
BTW, according to the original plan hdds profile should be turned off by
default, so qbt shouldb't check the ozone subproject. I am not sure which one
is better I am open to both: 1) check everything in one qbt, or use two qbts:
one for hadoop one for ozone
>From technical point of view I think all the requirements can be implemented
>both by only one (hadoop) or two (hadoop + ozone) personalities. For me using
>hadoop + ozone personalities seems to be a more clean separation. To put
>everything in the hadoop personality makes it more complex and we need a lot
>of additional condition. Dont' we?
(And there is a bigger chance to break something on the pure hadoop side with
an ozone modification in the hadoop personality).
> Create customized yetus personality for ozone
> ---------------------------------------------
>
> Key: HDDS-891
> URL: https://issues.apache.org/jira/browse/HDDS-891
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
>
> Ozone pre commit builds (such as
> https://builds.apache.org/job/PreCommit-HDDS-Build/) use the official hadoop
> personality from the yetus personality.
> Yetus personalities are bash scripts which contain personalization for
> specific builds.
> The hadoop personality tries to identify which project should be built and
> use partial build to build only the required subprojects because the full
> build is very time consuming.
> But in Ozone:
> 1.) The build + unit tests are very fast
> 2.) We don't need all the checks (for example the hadoop specific shading
> test)
> 3.) We prefer to do a full build and full unit test for hadoop-ozone and
> hadoop-hdds subrojects (for example the hadoop-ozone integration test always
> should be executed as it contains many generic unit test)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
