[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777522#comment-16777522
]
Tsz Wo Nicholas Sze commented on HDDS-699:
------------------------------------------
[~Sammi] thanks for the update. Thanks for adding many tests.
Using AtomicInteger and AtomicReference may not work since individual fields
may be mutated during a computation of a method. For example, when calling
sortByDistanceCost, all nodes are in the topology initially. Then, some of the
nodes may be removed during the computation of sortByDistanceCost.
sortByDistanceCost may return incorrect results.
I just have realized that the patches here are mostly adding new code but not
yet change the existing code to use the new NetworkTopology. Then, the 01
patch actually is better. We may make NetworkTopology pluggable and improve
it later.
How about you address the previous comments from the 01 patch (using a single
RW-lock)?
> Detect Ozone Network topology
> -----------------------------
>
> Key: HDDS-699
> URL: https://issues.apache.org/jira/browse/HDDS-699
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Sammi Chen
> Priority: Major
> Attachments: HDDS-699.00.patch, HDDS-699.01.patch, HDDS-699.02.patch
>
>
> Traditionally this has been implemented in Hadoop via script or customizable
> java class. One thing we want to add here is the flexible multi-level support
> instead of fixed levels like DC/Rack/NG/Node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
