[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783674#comment-16783674
]
Hadoop QA commented on HDDS-699:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
23s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 18 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
50s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 24m
18s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 19m
0s{color} | {color:red} root in trunk failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
1s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
37s{color} | {color:red} dist in trunk failed. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 47s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-ozone/dist {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
38s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
21s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
21s{color} | {color:red} dist in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 19m
3s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 19m 3s{color}
| {color:red} root in the patch failed. {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
4m 4s{color} | {color:orange} root: The patch generated 4 new + 0 unchanged -
0 fixed = 4 total (was 0) {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
35s{color} | {color:red} dist in the patch failed. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
32s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 17 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
22s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 44s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-ozone/dist {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
41s{color} | {color:red} hadoop-hdds/common generated 9 new + 0 unchanged - 0
fixed = 9 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
24s{color} | {color:green} common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 36s{color}
| {color:red} dist in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
47s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}114m 34s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdds/common |
| | instanceof will always return true for all non-null values in
org.apache.hadoop.hdds.scm.net.InnerNodeImpl.getNodes(int), since all
org.apache.hadoop.hdds.scm.net.InnerNodeImpl are instances of
org.apache.hadoop.hdds.scm.net.InnerNode At InnerNodeImpl.java:for all
non-null values in org.apache.hadoop.hdds.scm.net.InnerNodeImpl.getNodes(int),
since all org.apache.hadoop.hdds.scm.net.InnerNodeImpl are instances of
org.apache.hadoop.hdds.scm.net.InnerNode At InnerNodeImpl.java:[line 83] |
| | instanceof will always return true for all non-null values in
org.apache.hadoop.hdds.scm.net.InnerNodeImpl.getNumOfNodes(int), since all
org.apache.hadoop.hdds.scm.net.InnerNodeImpl are instances of
org.apache.hadoop.hdds.scm.net.InnerNode At InnerNodeImpl.java:for all
non-null values in
org.apache.hadoop.hdds.scm.net.InnerNodeImpl.getNumOfNodes(int), since all
org.apache.hadoop.hdds.scm.net.InnerNodeImpl are instances of
org.apache.hadoop.hdds.scm.net.InnerNode At InnerNodeImpl.java:[line 109] |
| | org.apache.hadoop.hdds.scm.net.InnerNodeImpl.getAncestorsI(Collection,
int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int)
instead At InnerNodeImpl.java:Integer(int) constructor; use
Integer.valueOf(int) instead At InnerNodeImpl.java:[line 544] |
| | org.apache.hadoop.hdds.scm.net.InnerNodeImpl doesn't override
NodeImpl.equals(Object) At InnerNodeImpl.java:At InnerNodeImpl.java:[line 1] |
| | Redundant nullcheck of excludedNodes, which is known to be non-null in
org.apache.hadoop.hdds.scm.net.InnerNodeImpl.getLeaf(int, String, Collection)
Redundant null check at InnerNodeImpl.java:is known to be non-null in
org.apache.hadoop.hdds.scm.net.InnerNodeImpl.getLeaf(int, String, Collection)
Redundant null check at InnerNodeImpl.java:[line 398] |
| | Redundant nullcheck of excludedScope, which is known to be non-null in
org.apache.hadoop.hdds.scm.net.InnerNodeImpl.getLeaf(int, String, Collection,
int) Redundant null check at InnerNodeImpl.java:is known to be non-null in
org.apache.hadoop.hdds.scm.net.InnerNodeImpl.getLeaf(int, String, Collection,
int) Redundant null check at InnerNodeImpl.java:[line 504] |
| | org.apache.hadoop.hdds.scm.net.NetUtils.removeDuplicate(NetworkTopology,
Collection, String, int) makes inefficient use of keySet iterator instead of
entrySet iterator At NetUtils.java:inefficient use of keySet iterator instead
of entrySet iterator At NetUtils.java:[line 114] |
| |
org.apache.hadoop.hdds.scm.net.NodeSchemaLoader.loadTopologySection(Element,
Map) makes inefficient use of keySet iterator instead of entrySet iterator At
NodeSchemaLoader.java:of keySet iterator instead of entrySet iterator At
NodeSchemaLoader.java:[line 322] |
| | Should
org.apache.hadoop.hdds.scm.net.NodeSchemaLoader$NodeSchemaLoadResult be a
_static_ inner class? At NodeSchemaLoader.java:inner class? At
NodeSchemaLoader.java:[lines 79-89] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HDDS-699 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12961017/HDDS-699.03.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle xml shellcheck shelldocs |
| uname | Linux 73ceeb2b8ba0 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct
5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 15098df |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| compile |
https://builds.apache.org/job/PreCommit-HDDS-Build/2433/artifact/out/branch-compile-root.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HDDS-Build/2433/artifact/out/branch-mvnsite-hadoop-ozone_dist.txt
|
| shellcheck | v0.4.6 |
| findbugs | v3.1.0-RC1 |
| mvninstall |
https://builds.apache.org/job/PreCommit-HDDS-Build/2433/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HDDS-Build/2433/artifact/out/patch-compile-root.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HDDS-Build/2433/artifact/out/patch-compile-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HDDS-Build/2433/artifact/out/diff-checkstyle-root.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HDDS-Build/2433/artifact/out/patch-mvnsite-hadoop-ozone_dist.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDDS-Build/2433/artifact/out/whitespace-tabs.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDDS-Build/2433/artifact/out/new-findbugs-hadoop-hdds_common.html
|
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/2433/artifact/out/patch-unit-hadoop-ozone_dist.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDDS-Build/2433/testReport/ |
| Max. process+thread count | 306 (vs. ulimit of 10000) |
| modules | C: hadoop-hdds/common hadoop-ozone/dist U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HDDS-Build/2433/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Detect Ozone Network topology
> -----------------------------
>
> Key: HDDS-699
> URL: https://issues.apache.org/jira/browse/HDDS-699
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Sammi Chen
> Priority: Major
> Attachments: HDDS-699.00.patch, HDDS-699.01.patch, HDDS-699.02.patch,
> HDDS-699.03.patch
>
>
> Traditionally this has been implemented in Hadoop via script or customizable
> java class. One thing we want to add here is the flexible multi-level support
> instead of fixed levels like DC/Rack/NG/Node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
