[ 
https://issues.apache.org/jira/browse/HDFS-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116910#comment-13116910
 ] 

Doug Cutting commented on HDFS-2298:
------------------------------------

> Doug you argued against this.

I still don't like version numbers in methods, but, if semantics are changed in 
a way that cannot be handled otherwise and there's not an obvious better name, 
I don't see an alternative.  Do you?

Nice of you to look for inconsistencies in what I've said, though.  Thanks!

> Given that this has been open for a while, for now can you turn off the test?

I'd prefer to either fix it or remove the code than just disable the test.  If 
there's no will to use Avro RPC in Hadoop then better it should just be 
removed, no?  Sanjay's actively pursuing version interoperability through 
different means, so maybe it's time to remove this stuff.

This has been patch-available, +1'd and passing tests for a few weeks.  Someone 
should have committed it.  Someone like me, I guess, but I was reluctant since 
I've not been that active here lately.  Tests were passing, but have since been 
broken by HADOOP-7524.  I worked today to address that, but if someone instead 
promotes a patch to remove Avro RPC altogether then I'll stop trying to fix 
this.

So, no, I do not intend to turn off the test.  But if you'd like to 'fix' this 
that way, go ahead, I won't block you.

                
> TestDfsOverAvroRpc is failing on trunk
> --------------------------------------
>
>                 Key: HDFS-2298
>                 URL: https://issues.apache.org/jira/browse/HDFS-2298
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>            Reporter: Aaron T. Myers
>            Assignee: Doug Cutting
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HDFS-2298.patch, HDFS-2298.patch, HDFS-2298.patch, 
> HDFS-2298.patch, HDFS-2298.patch
>
>
> The relevant bit of the error:
> {noformat}
> -------------------------------------------------------------------------------
> Test set: org.apache.hadoop.hdfs.TestDfsOverAvroRpc
> -------------------------------------------------------------------------------
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.486 sec <<< 
> FAILURE!
> testWorkingDirectory(org.apache.hadoop.hdfs.TestDfsOverAvroRpc)  Time 
> elapsed: 1.424 sec  <<< ERROR!
> org.apache.avro.AvroTypeException: Two methods with same name: delete
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to