[ 
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908857#comment-13908857
 ] 

Haohui Mai commented on HDFS-5939:
----------------------------------

bq. I on purposely added it, so in the log file for the same test class, we 
have a delimiter message for a given test.

You can run it through mvn or eclipse. An analogy is that we don't write the 
code that calls {{System.out.println}} for every request.

bq. About checking "no datanode" in exception message...

I'm fine with that, but in the new patch the unit test is still broken (see the 
previous round of review).

bq. I not only was not able to reproduce the original problem.

I can reproduce it on trunk:

{noformat}
curl -X PUT "http://localhost:50070/webhdfs/v1/asd?op=CREATE";
{"RemoteException":{"exception":"IllegalArgumentException","javaClassName":"java.lang.IllegalArgumentException","message":"n
 must be positive"}}
{noformat}

If you find a new issue, you're more than welcome to file a new jira. However, 
so far it looks to me that it is a duplicate issue of this one.

Thanks for providing a new patch, but I think that all previous comments from 
[~szetszwo] and me are quite comprehensive, and all of them need to be fully 
addressed before giving my +1.

> WebHdfs returns misleading error code and logs nothing if trying to create a 
> file with no DNs in cluster
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5939
>                 URL: https://issues.apache.org/jira/browse/HDFS-5939
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 2.3.0
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HDFS-5939.001.patch, HDFS-5939.002.patch, 
> HDFS-5939.003.patch, HDFS-5939.004.patch
>
>
> When trying to access hdfs via webhdfs, and when datanode is dead, user will 
> see an exception below without any clue that it's caused by dead datanode:
> $ curl -i -X PUT 
> ".../webhdfs/v1/t1?op=CREATE&user.name=<userName>&overwrite=false"
> ...
> {"RemoteException":{"exception":"IllegalArgumentException","javaClassName":"java.lang.IllegalArgumentException","message":"n
>  must be positive"}}
> Need to fix the report to give user hint about dead datanode.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to