[ 
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908958#comment-13908958
 ] 

Haohui Mai commented on HDFS-5939:
----------------------------------

bq.  it's just one per test function, not too many. I find it useful to look at 
test result.

I'm not a big fan of verbose code. If you want it for debugging, you can always 
make the modification locally, I don't see the value of putting it into the 
repo.

bq.  About the two broken tests,..

Sorry for the confusion, what I meant is that the new unit test in the patch is 
incorrect. You can find the explanation in the previous comments.

This unit test reproduces the problem.

{code}
    MiniDFSCluster cluster = null;
    Configuration conf = new Configuration();
    try {
      cluster = new MiniDFSCluster.Builder(conf).numDataNodes(0).build();
      // Set the replication factor to 1 so that webhdfs can create the file
      conf.setInt(DFSConfigKeys.DFS_REPLICATION_KEY, 1);
      cluster.waitActive();
      FileSystem fs = WebHdfsTestUtil.getWebHdfsFileSystem(conf,
          WebHdfsFileSystem.SCHEME);
      fs.create(new Path("/asdf")).close();
    } finally {
      if (cluster != null) {
        cluster.shutdown();
      }
    }
{code}

> WebHdfs returns misleading error code and logs nothing if trying to create a 
> file with no DNs in cluster
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5939
>                 URL: https://issues.apache.org/jira/browse/HDFS-5939
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 2.3.0
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HDFS-5939.001.patch, HDFS-5939.002.patch, 
> HDFS-5939.003.patch, HDFS-5939.004.patch
>
>
> When trying to access hdfs via webhdfs, and when datanode is dead, user will 
> see an exception below without any clue that it's caused by dead datanode:
> $ curl -i -X PUT 
> ".../webhdfs/v1/t1?op=CREATE&user.name=<userName>&overwrite=false"
> ...
> {"RemoteException":{"exception":"IllegalArgumentException","javaClassName":"java.lang.IllegalArgumentException","message":"n
>  must be positive"}}
> Need to fix the report to give user hint about dead datanode.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to