[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911017#comment-13911017
]
Haohui Mai commented on HDFS-5939:
----------------------------------
The patch mostly looks good. Three more minor issues:
{code}
+ public void testNoDatanode() throws Exception {
{code}
Can you rename the test to convey more information? For example,
{{testCreateWithNoDN}}?
{code}
+ fs.create(new Path("/testnodatanode")).close();
+ } catch (IOException ex) {
...
{code}
The code needs to call {{Assert.fail()}} right after {{fs.create()}}.
{code}
+ LOG.info("Caught exception \"" + ex + "\" " +
+ (expected? " as expected." : "unexpectedly."));
{code}
You might want to remove this message as well.
> WebHdfs returns misleading error code and logs nothing if trying to create a
> file with no DNs in cluster
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-5939
> URL: https://issues.apache.org/jira/browse/HDFS-5939
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Affects Versions: 2.3.0
> Reporter: Yongjun Zhang
> Assignee: Yongjun Zhang
> Attachments: HDFS-5939.001.patch, HDFS-5939.002.patch,
> HDFS-5939.003.patch, HDFS-5939.004.patch, HDFS-5939.005.patch,
> HDFS-5939.006.patch
>
>
> When trying to access hdfs via webhdfs, and when datanode is dead, user will
> see an exception below without any clue that it's caused by dead datanode:
> $ curl -i -X PUT
> ".../webhdfs/v1/t1?op=CREATE&user.name=<userName>&overwrite=false"
> ...
> {"RemoteException":{"exception":"IllegalArgumentException","javaClassName":"java.lang.IllegalArgumentException","message":"n
> must be positive"}}
> Need to fix the report to give user hint about dead datanode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
