[
https://issues.apache.org/jira/browse/HDFS-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127392#comment-14127392
]
Chris Douglas commented on HDFS-6940:
-------------------------------------
bq. This issue is being rejected based on an anticipation of some future
interfaces (which I agreed to discuss), rather than technical objections to the
patch.
Relaxing the visibility of methods makes an interface of them. By way of
example (beyond those [~atm] cited), the refactoring also changes methods
explicitly tagged as {{@VisibleForTesting}} to be public. Other interfaces may
be built on top of these as you intend, but the objection is that this
_already_ creates new APIs that users could extend, believing them to be
stable. While the methods added by the patch may be a coherent, logical set,
the rationale is neither documented nor codified in an interface/plugin.
> Initial refactoring to allow ConsensusNode implementation
> ---------------------------------------------------------
>
> Key: HDFS-6940
> URL: https://issues.apache.org/jira/browse/HDFS-6940
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: 2.0.6-alpha, 2.5.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 2.6.0
>
> Attachments: HDFS-6940.patch
>
>
> Minor refactoring of FSNamesystem to open private methods that are needed for
> CNode implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
