[
https://issues.apache.org/jira/browse/HDFS-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139556#comment-14139556
]
Charles Lamb commented on HDFS-6987:
------------------------------------
Hi Zhe,
I took a quick look and have some trivial comments:
Several lines bust the 80 char limit.
EncryptionZoneManager.java
createEncryptionZone adds an extra newline.
FSDirectory.java
Should we be using NameNode.LOG instead of FSNamesystem.LOG? NameNode.LOG seems
to be the norm in this file.
In setFileEncryptionInfo there's a blank line you introduced which probably
doesn't enhance the readability.
To Andrew's point about "Ind", I agree that it's ambiguous. But looking at the
.proto file, it looks like you mean "Individual" rather than INode. If that's
the case, then Indiv or Individ might be better?
Personally, I like to use final a lot, but that's my own hobby horse.
> Move CipherSuite xattr information up to the encryption zone root
> -----------------------------------------------------------------
>
> Key: HDFS-6987
> URL: https://issues.apache.org/jira/browse/HDFS-6987
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: encryption
> Reporter: Andrew Wang
> Assignee: Zhe Zhang
> Attachments: HDFS-6987-20140917-v1.patch
>
>
> All files within a single EZ need to be encrypted with the same CipherSuite.
> Because of this, I think we can store the CipherSuite once in the EZ rather
> than on each file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
