[
https://issues.apache.org/jira/browse/HDFS-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141274#comment-14141274
]
Charles Lamb commented on HDFS-6987:
------------------------------------
Hi Zhe,
I only have a few nits:
EncryptionZone:
* Typo s/paht/path/
FSDirectory:
* Looks like you introduced an extra newline in setFileEncryptionInfo (line
2807).
* s/if(/if (/
* unprotectedGetXAttrByName, xAttrName is unused. Eliminate?
FSNamesystem:
* startFileInternal. You could move the dangling ");" up to the previous line.
INodesInPath:
* getINodes. The javadoc and the TODO seem to contradict each other.
> Move CipherSuite xattr information up to the encryption zone root
> -----------------------------------------------------------------
>
> Key: HDFS-6987
> URL: https://issues.apache.org/jira/browse/HDFS-6987
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: encryption
> Reporter: Andrew Wang
> Assignee: Zhe Zhang
> Attachments: HDFS-6987-20140917-v1.patch,
> HDFS-6987-20140918-v1.patch, HDFS-6987-20140919-v1.patch
>
>
> All files within a single EZ need to be encrypted with the same CipherSuite.
> Because of this, I think we can store the CipherSuite once in the EZ rather
> than on each file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
