Hi Esteban.

2014-03-12 4:48 GMT+01:00 Esteban Campostrini <[email protected]>:

> >
> > This is rather weird. Because inside the file there is fpos_t and I do
> not understand how is it possible that it reports posix_fpos_t. At this
> phase it shall not see the posix_ prefix at all. What happens if you run
> only the preprocessor?
>
> My bad here, I replaced beforehand the occurrences of fpos_t with
> posix_fpos_t after grepping in HelenOS headers. I forgot to
> take that out to reproduce the original error. I'm sorry.
> This is actually the original error:
>
> contrib/tools/pngfix.c:868:19: error: field 'data_pos' has incomplete type
>     fpos_t         data_pos;      /* Position of first byte of chunk data
> */
>                    ^
>
This makes more sense :-). fpos_t is only a forward declaration so you need
to move the definition to the header.

Cheers,
- Vojta



> contrib/tools/pngfix.c:1550:19: error: field 'chunk_data_pos' has
> incomplete type
>     fpos_t         chunk_data_pos;    /* Position of first byte of chunk
> data */
>                    ^
> contrib/tools/pngfix.c: In function 'zlib_check':
> contrib/tools/pngfix.c:2615:11: error: storage size of 'start_pos' isn't
> known
>     fpos_t start_pos;
>            ^
> I don't really get what is wrong, my guess is some header is missing
> but I'm not quite sure, stdio.h is included in pngfix.
>
> > Actually, it is there:
> > typedef struct _posix_fpos __POSIX_DEF__(fpos_t);
> > and
> > struct _posix_fpos {
> >     off64_t offset;
> > };
> > the problem is somewhere around this. But I do not see it now.
>
> Yes, I saw that and I replaced fpos_t with _posix_fpos since I thought
> the problem was that it couldn't find a declaration
> but it looks that there's something else to be done.
>
> > I have a suggestion. How about forking the coastline repo and committing
> the harbour there (even if it does not work)? It would help me quite a lot
> when reproducing this. Regarding the patch to math.h - keep it there as
> well with comment that it has to be applied to mainline. How about that?
>
> I totatlly agree. I already forked it and commited the harbour, the
> patch and some notes.
>
> Cheers,
> Esteban
>
> _______________________________________________
> HelenOS-devel mailing list
> [email protected]
> http://lists.modry.cz/listinfo/helenos-devel
>
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel

Reply via email to