Hi Esteban.
2014-03-12 20:58 GMT+01:00 Esteban Campostrini <[email protected]>: > Hi Vojta, > > Thanks for the help! After that and some other small modifications the > make phase finally ends without errors. > Good job :-). I executed the binary pngtest on HelenOS and it seems to run OK. Would > you mind taking a look at it? All the changes > have been pushed to the repository. > After some kicking I was able to build it too ;-). I have few comments. The code deserves some cleaning. I know it is still WIP state but I really do not want to merge it in this state. Your code still expects to be executed inside coastline directory. That is wrong. As a matter of fact I think it even complicates testing. And it prevents adding libpng to the matrix builder. You need to add the CPPFLAGS. I do not understand how it could work without them. If you look for .dfn.out target in the main Makefile, you would see it calls C preprocessor. This preprocessor will not see HelenOS include directories unless specified through CPPFLAGS. Actually, this prevented me from building libpng for ia32 on x86_64 Linux. It would be nice if package() would install the pngtest.png as well to allow running the tests out of the box. Btw, have you tried building for different architecture than ia32? One final note. I know that the documentation for porting software to HelenOS is rather minimal (apart from existing harbours there are only few rants on my blog). That is why I tried to offer as much guidance as possible. But that won't be possible during the coding period if you are accepted into GSoC. Now, I was solving technical details for you and that won't work during the summer. But you are probably aware of this and you would plan accordingly in your application. Cheers, - Vojta > > Cheers, > Esteban > >
_______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/listinfo/helenos-devel
