Hi Vojta,
Thanks for the feedback.
> I have few comments.
>
> The code deserves some cleaning. I know it is still WIP state but I really
> do not want to merge it in this state.
I made some cleaning. Basically I removed the unnecessary code.
> Your code still expects to be executed inside coastline directory. That is
> wrong. As a matter of fact I think it even complicates testing. And it
> prevents adding libpng to the matrix builder.
I already made the changes to that.
>
> You need to add the CPPFLAGS. I do not understand how it could work without
> them. If you look for .dfn.out target in the main Makefile, you would see it
> calls C preprocessor. This preprocessor will not see HelenOS include
> directories unless specified through CPPFLAGS. Actually, this prevented me
> from building libpng for ia32 on x86_64 Linux.
>
I didn't have problems at least during the building regarding this
(that's why I commented it),
but thanks for letting me know that. The flags were added.
> It would be nice if package() would install the pngtest.png as well to allow
> running the tests out of the box.
I added that too.
All these changes have been pushed to the repo.
> Btw, have you tried building for different architecture than ia32?
Right now I'm trying to build for ia64. There was no problem while
building HelenOS image, and
the binaries that were built for ia32 with the coastline still run there.
When I try to build HelenOS from the coast for ia64 it complains when
is doing the configuration
for ia64:
Configuration error: The presets are ambiguous
I'm looking into this.
>
> One final note. I know that the documentation for porting software to
> HelenOS is rather minimal (apart from existing harbours there are only few
> rants on my blog). That is why I tried to offer as much guidance as
> possible. But that won't be possible during the coding period if you are
> accepted into GSoC. Now, I was solving technical details for you and that
> won't work during the summer. But you are probably aware of this and you
> would plan accordingly in your application.
Thanks for this note and yes, I'm aware of it. I know things haven't
been quite smooth so far
and I know that I still have several things to read and learn
regarding the project chosen. I will try to be
as realistic as possible regarding the proposal.
Cheers,
Esteban
>>
>
>
> _______________________________________________
> HelenOS-devel mailing list
> [email protected]
> http://lists.modry.cz/listinfo/helenos-devel
>
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel
