Hi Jirka, On 11/13/19 1:49 PM, Jiri Svoboda wrote: > > I think we need to consider a few more things. The switch to Meson was a > big change and IMHO the outcome is overall very good and I am happy > about it. > > I think we regressed in a few more areas, the old build system made it > easy to look at disassembly and at examine object files. Also what about > "make check"? I think these are areas that may still need some work.
For make check you now run build_all.sh which has basically the same effect. You still need to run make ccheck separately. As you can see on the example of doxygen, we (and especially JZv) are trying to fix the things. Also iteratively. > Also, we are not a professional/commercial software house with paid > developers and customers. We can afford to fix things later. And in > general we do and have always done. > > Quite to the contary. While our software does not fly airplanes, since > we *don't* have the paid people who can be tasked with fixing breakages. > We simply cannot afford to tolerate breakages postponing the fixes for > "later" (effectively fo somebody else). This will only frustrate the > handful contributors we have. I think in this case this goal was unrealistic. The Meson branch was in a pretty good shape for HelenOS/master. Merging at this stage was IMO justified and helped to avoid bitrot (still remember waf and all the student branches?). I specifically remember we were contemplating what needs to be done for coastline/ci. The belief then was that additional software needs to be installed on the CI build machine (where we have no access) and everything would just fall in line. In this we unfortunately arrived at a wrong decision. The realization of that fact took us about a month and a half when I initiated private communication with Vojta. My impression was that CI was already unmaintained as its broken state provoked no other action. JZv then instantly provided an initial fix for CI which would have helped a bit on its own had it been deployed. This fix was deployed only a couple of days ago, basically when this thread started. So did we plan to break CI indefinitely? Certainly not. Yes, we could and should have realized what was wrong with CI earlier. Our false beliefs, reinforced by the inaccessibility of the CI deployment server (it was just a couple of packages that needed to be installed, right?), prolonged this situation. > We cannot make exceptions to this rule, be it for desirability of a > featre, "momentum" of HelenOS camp or anything else. We wouldn't break HelenOS master as it is the most important one. I think we were entitled to temporarily break the CI server under the circumstances. And yes, it should have been fixed faster. Jakub > > > Regards, > > Jiri > > > Jakub > > > > > Cheers, > > Jiri > > > > > > ---------- Původní e-mail ---------- > > Od: Vojtech Horky <[email protected]> > > Komu: HelenOS development mailing list <[email protected]> > > Datum: 12. 11. 2019 23:35:58 > > Předmět: [HelenOS-devel] Notes on last CI update > > > > > > Hello, > > > > I have updated CI scripts on the CI server and new build just > finished. > > > > TL;DR: Follows about 5 paragraphs of complaints and shed tears ;-). > > Ended by brief summary of the last build. > > > > First of all, I understand that everyone is working on HelenOS in his > > spare time but I do not think that should be an excuse for breaking > > things and creating extra load on others. I acknowledge that I am > > responsible for ci.helenos.org and that my lack of time caused that it > > was in such bad shape recently. But at least some things could have > > been prevented. > > > > Please, next time when there is such a big update (I mean things like > > Meson etc.) it would be nice if someone would contact me in advance. > > You know, just a short e-mail "hey, could you try this on CI machine > > before we merge it into mainline so we have seamless transition?". And > > yes, I am receiving e-mails from GitHub but automated notifications > > simply got lower priority than normal e-mail. > > > > It would be also nice if changes to the build system would be > > propagated to other repositories too. CI script was broken for about 2 > > months, the hotfix from 99d248b is not really complete. Not dwelling > > on the fact that we needed two rounds of e-mails before the problem > > was even acknowledged. > > > > @le-jzr: have you ever tried to run the CI script or you do just > > search-and-replace when "fixing" it? I understand that it is not a > > ten-liner any more but we do not have anything better at the moment. > > Or do we? > > > > And this is really not the first time similar thing has happened. > > Honestly, it just kills my motivation to work on HelenOS. > > > > > > Regarding last build: > > > > HelenOS seems to be built okay, tests with bare images are more or > > less fine too. > > > > Some harbours are failing as before, gzx, msim and sycek are broken > > for all platforms. > > > > It seems that building extended images (e.g. HelenOS with binutils) is > > broken as all tests fail with "command not found". > > > > As an improvement, it would be nice if ninja inside CI would not be > > that smart about parallelism level. The jobs are already running in > > parallel and running the inner build in parallel too only increases > > the chances that the build would fail. > > > > Cheers, > > - Vojta > > > > _______________________________________________ > > HelenOS-devel mailing list > > [email protected] > > http://lists.modry.cz/listinfo/helenos-devel > > > > > > _______________________________________________ > > HelenOS-devel mailing list > > [email protected] > > http://lists.modry.cz/listinfo/helenos-devel > > > > _______________________________________________ > HelenOS-devel mailing list > [email protected] > http://lists.modry.cz/listinfo/helenos-devel > > > _______________________________________________ > HelenOS-devel mailing list > [email protected] > http://lists.modry.cz/listinfo/helenos-devel > _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/listinfo/helenos-devel
