On 11/14/05, ScratchMonkey <[EMAIL PROTECTED]> wrote:
> --On Monday, November 14, 2005 10:28 AM +0000 Ben Kennish
> <[EMAIL PROTECTED]> wrote:
>
> > Some will say bad design.  Some will say optimisation.
>
> And the latter would be wrong, as you should never optimize until you know
> where the bottlenecks are. Otherwise you're wasting programmer time.
> Especially when you consider that the workaround is to pull a file *from
> another server* via URL, which is grossly more pessimal.
>
> This looks like some junior programmer was using an array on the stack
> instead of a string class (which would grow to accomodate any size). Very
> bad style for production code. And generally not needed even in a quick
> test hack, given the availability of good string classes in almost any
> framework.

Yeah but limits are important.  Allowing motd.txt to be infinite
(limited to available memory) has no advantages really.  And if your
motd is more than a few thousand characters I seriouly doubt anyone is
reading it anyways.  If there were no motd.txt limit I'd link it to
/dev/urandom and let all players that connected hang indefinately ;-)

-sb

_______________________________________________
To unsubscribe, edit your list preferences, or view the list archives, please 
visit:
http://list.valvesoftware.com/mailman/listinfo/hlds_linux

Reply via email to