Hello!
Gilles Detillieux wrote:
> According to Geoff Hutchison:
> > At 1:18 PM +0300 11/22/99, Alexis Mikhailov wrote:
> > >Can I propose a patch? It allows better handling of local files through
[snip]
> I've looked through, and the patch contains a number of different (sometimes
> loosely related) fixes and enhancements:
>
Sorry about not suppling comments the first place. I've completly
forgot to create them.
> 1) htcommon/DocumentDB.cc & htdig/Retriever.cc: allow file:... as well
> as http:... URLs. (This doesn't change anything in htlib/URL.cc, so I'm
I's true.
[snip]
> 2) htdig/HTML.cc: add support for an ignore_noindex attribute. This is
> undocumented and no default is defined, but I think the behaviour is
> pretty obvious from the code. I'd question the desirability/need for
> this, but it seems harmless enough. The value should be set in a static
> variable, though, to minimise performance impact. I'd call this a work
> in progress.
This variable was added to allow index of local files with NOINDEX tag.
For example, all Qt documentation files contain this tag. I thought
it would be not interesting to remove this tag in every file by hand,
so I created this variable. Forgot about default value though.
[snip]
> 4) htdig/htdig.cc & htlib/String.cc: allow htdig to read URL list from
> stdin if htdig given an argument of "-". The >> operator added to the
> String class uses a lot of stuff I've never seen before, so I don't know
> how to judge it for myself. It seems more complicated that it would
> need to be for the simple task at hand - all you need to do is load all
> of stdin into one string - but I guess the line by line approach would
> allow bigger lists (less string overhead). Undocumented.
Was copied from ba_string.c (IIRC) (STL's string class). Though modified
to allow only '\n' to go as end of string.
[snip]
> 6) htlib/cgi.cc & htsearch/htsearch.cc: add a -a option to htsearch, to
> add name=value parameters to those in query string. This is undocumented
> as well. I'm not sure how it relates to the other changes, but it seems
> simple enough.
This option was added to simplify calling of htsearch from external
program. Of course it was possible to set enviroment variables to
emulate
CGI call, but it seemed unnecessary complicated.
> 7) htsearch/htsearch.cc: set alarm() time earlier in execution than was
> done before. Didn't know that the initial processing could lead to hangs.
It didn't lead. I've moved it together with moving declaration of input
variable in case constructor of cgi class do something that could hang.
> 8) htsearch/Display.cc: compare nPages to maximum_pages earlier than was
> done before, presumably so PAGES variable won't be allowed to exceed it.
Also to not display '1', '2' etc. buttons in the end of page if
maximum_pages = 1.
> I'm all for these fixes, but some documentation explaining the less
> clear aspects, or even a note explaining the rationale for these,
> would be appreciated.
As I have writen in the letter with patch, all this changes were done
to allow using of htdig as index engine to KDevelop. I tried to make
changes as general as possible to be useful not only to KDevelop.
> I do have some concerns about the correctness of (1) above, given the
> lack of changes to URL.cc. Maybe this would be a better fit in 3.2.
I'll check it again and will try to look as it is now in CVS version.
> I'm also concerned about the portability of the >>
> operator added to the String class in (4) above, given the way it pokes
> into internals of library classes, and the unfamiliar cast construct.
Copied from STL, should be portable.
> Separate patches for these would be a big help, as fixes are generally
> committed one at a time.
Sorry again, I'm still new to working with community.
Alexis
------------------------------------
To unsubscribe from the htdig3-dev mailing list, send a message to
[EMAIL PROTECTED]
You'll receive a message confirming the unsubscription.
