[ http://issues.apache.org/jira/browse/HTTPCORE-11?page=all ]
Oleg Kalnichevski updated HTTPCORE-11:
--------------------------------------
Attachment: conn.patch
Sorry about the confusion. Indeed, comm.patch was the second patch.
> - "volatile boolean open" and isOpen/assertOpen/assertNotOpen could be moved
> to AbstractHCC (?)
I would not like to do that. There may be different ways to test whether a
connection is open or not. A little bit of code duplication is a very small
price to pay for extra flexibility.
> - "private static boolean startsWithHTTP" in AbstractHCC should be protected
> or public
Done
> Should we define a container class that holds
> transmitter/receiver/(de)serialiser and is used by client and server
> implementations?
> That would eliminate the duplicate attributes, getters, and setters. Except
> for the new container of course.
I am not sure that buys us a lot. I suspect these days lots of folks would like
to use an IoC framework to initialize their components. Plain setters and
getters are a little more consistent with the way IoC containers work.
New patch would cleanly apply against SVN trunk. Please take a look.
Oleg
> Provide generic server and client connection primitives that can work with
> arbitrary HTTP data receivers and transmitters.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HTTPCORE-11
> URL: http://issues.apache.org/jira/browse/HTTPCORE-11
> Project: HttpComponents Core
> Issue Type: Improvement
> Components: HttpCore
> Affects Versions: 4.0-alpha2
> Reporter: Oleg Kalnichevski
> Assigned To: Oleg Kalnichevski
> Fix For: 4.0-alpha3
>
> Attachments: conn.patch, httpcore-abstractconn.patch
>
>
> Provide generic server and client connection primitives that can work with
> arbitrary HTTP data receivers and transmitters. The default connection
> primitives in their present form are tightly coupled with the java.net.Socket
> class. There are cases when the underlying I/O transport is based on
> different media (MINA transport, NIO channels)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
