On Tue, 2006-09-05 at 14:56 +0200, Roland Weber wrote: > Hi Oleg, > > I had a quick look and will share my initial thoughts here. Maybe I'll think > differently after chewing on this for a while. Or maybe you can add some > ideas of yours in response. > > (1) agreed. I hadn't seen that point before. > > (2) A connection manager (and/or operator) is responsible for more than one > connection. Per-connection information is best kept with the connection > itself. I don't see why the information shouldn't be publicly accessible in a > read-only fashion. It allows for the implementation of strategies that are > not tied to a specific connection manager (or whatever) implementation. > Such as "don't keep connections to host XYZ alive".
Hi Roland, I certainly do not have a problem with exposing the target host through the HttpClientConnection interface. We just have to make sure that HttpClientConnection cannot be (easily) put into an inconsistent state where the target host does not correspond to the remote address of the underlying socket. > > (3) agreed > > Two weeks ago we discussed turning the connections into simple containers > that don't know how to establish a connection. While your patch does achieve > that, it also effectively turns connections into throw-away objects. On first > thought, I don't like it because of a gut feeling. On second thought I don't > like it because SimpleHttpDispatcher assumes to have *one* connection which > can be pointed to different targets one after another. It's probably not hard > to change, but throw-away connection objects clash with every thought about > "connection management" I've ever had so far. > The trouble is that I would not want the HttpClientConnection interface to be directly coupled with java.net.Socket. At the same time I cannot think of an elegant way to re-attach the existing client connection to a new network socket. Let us think it over. Oleg > cheers, > Roland > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
