[
http://issues.apache.org/jira/browse/HTTPCORE-11?page=comments#action_12432368
]
Roland Weber commented on HTTPCORE-11:
--------------------------------------
Hi Oleg,
I guess I'll never ever be able to apply a patch without some kind of problem.
The patch tool didn't like the removed class, obviously because of expanded
$Revision$ and other tags. I deleted the class manually. What did the
subversion guys think when they implemented "svn diff" without a matching "svn
patch"?
The patch looks good by itself, but it raises some questions regarding
HTTPCORE-8. Most of them can be discussed as part of HTTPCORE-8, but there is
one thing I'd like to mention at this time: the class names. HTTPCORE-8 and
this patch both define an AbstractHttpClientConnection class. In HTTPCORE-8,
the class implements only the logic mandated by the interface, here it also
adds the receiver/transmitter/(de)serializer objects for our default
implementation.
I would not like to have both kinds of code in the same class. Think of an
embedded system where someone decides to implement the receive/transmit logic
in native code. The logic from HTTPCORE-8 would still be useful, but the
receiver/transmitter/(de)serializers would not. How do you think about renaming
the classes here to {Base|Basic}Http{Client|Server}Connection? Factoring out
the code mandated by the interface into AbstractHttp{Client|Server}Connection
could be done with HTTPCORE-8.
cheers,
Roland
> Provide generic server and client connection primitives that can work with
> arbitrary HTTP data receivers and transmitters.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HTTPCORE-11
> URL: http://issues.apache.org/jira/browse/HTTPCORE-11
> Project: HttpComponents Core
> Issue Type: Improvement
> Components: HttpCore
> Affects Versions: 4.0-alpha2
> Reporter: Oleg Kalnichevski
> Assigned To: Oleg Kalnichevski
> Fix For: 4.0-alpha3
>
> Attachments: conn.patch, httpcore-abstractconn.patch
>
>
> Provide generic server and client connection primitives that can work with
> arbitrary HTTP data receivers and transmitters. The default connection
> primitives in their present form are tightly coupled with the java.net.Socket
> class. There are cases when the underlying I/O transport is based on
> different media (MINA transport, NIO channels)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
