Hi Kay, On 4 Feb., 18:47, kfj <[email protected]> wrote: > Hi group! > > I've put online another patch for the hugin_scripting branch at my > bazaar repo, plus an updated readme file. This time there wasn't so > much change - it's more consolidation. I did rewrite hpi.py, though, > and hope it'll perform well now, no matter if the plugin is loaded as > a module or executed unconditionally.
Commited after some changes. * Don't misuse configure_file for installing files. Use the install command instead. * Your patch contains a lot a line, where only the line ending were changed. -> Unified * Some changes in your patch were already in the repo. You did not provide a patch against the head of the python branch. Also it would be nice, if one commit/changeset/patch would only address one issue. Putting all changes into one changeset is not recommended when using version management. This makes it harder to track changes and to find bug. > > I extended the demo plugin to demonstrate applying orientations to an > eight-shot sequence, and I wrote another one which keeps at most five > 'best' control points for each image pair. top_five.py is working here (standalone and in hugin). > > I also put in two SWIG interfaces, 'bogous.i' and 'vacine.i' which > demonstrate a problem I have on my system (Kubuntu 10.10 + Python 2.6) > and haven't been able to resolve. T. Modes has established that > Windows isn't affected, but noone seems to have checked on Linux so > far - I hope this time it isn't thrown out of the branch after the > patch is integrated. Apart from demonstrating my problem with hugin's > use of cerr when used from hsi, these files are harm- and useless and > should vanish later on. See my above comments. For this issue it is better if you provide a patch which contains only the interface bogous/vaccine, maybe with a readme. Then it would be easier for someone else to apply your patch and give feedback/solution. Thomas -- You received this message because you are subscribed to the Google Groups "Hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/hugin-ptx
