The problem with HuginStitchProject is that MacOpenFile gets called AFTER the variable is checked and the file chooser dialog opens and you having to open a project file. So sometime after it has already started processing the manually specified project file.
(I want to apologize in advance, I don't want to pressure you too much with all those feature requests and bugs.) Could you please save the specified output prefix in Hugin to file, currently it gets validated and then discarded (PanoPanel.cpp:1091). Niklas Am Mittwoch, 18. Mai 2016 19:09:35 UTC+2 schrieb T. Modes: > > > > Am Mittwoch, 18. Mai 2016 18:23:55 UTC+2 schrieb Niklas Mischkulnig: >> >> >> A few questions concerning changes I made while updating the self >>>> contained cmake build: >>>> What do you think about PTBatcherGui and HuginStitchProject opening >>>> files (see my post from 17:10)? >>>> >>> >>> Does this referring to calling PTBatcherGUI and HuginStitchProject from >>> Hugin or direct from the bundle? >>> >> >> So that you can open a file by right-clicking on it in the file-browser >> and then choosing "Open with..." (see Image). >> (This would be more useful with StitchProject than with PTBatcherGui) >> > > This is handled by MacOpenFile in the corresponding app class. This > function is specific to Mac OS. This is currently implemented for Hugin and > hugin_stitch_project, but not for PTBatcherGUI (it uses a normal command > line parsing of all the switches). > Maybe there was a change between wxWidgets 2.8 and 3.0. You need to debug > it on a Mac. (Maybe adding std::cout or wxLogMessage in these function to > check if it processes correctly the files). > > >> >>> Are these missing endl's in Executor.cpp intentional (see attached >>>> patch)? >>>> >>> I don't see an attached patch. >>> >> Oops, now? >> > > Yes. You are right. I committed your patch. > >> >> Can I include "hugin_config.h" in src/hugin1/base_wx/wxPlatform.h to >>>> include the MAC_SELF_CONTAINED_BUNDLE definition in files like >>>> Executor.cpp? >>>> >>> >>> I would prefer to include "hugin_config.h" into the source files >>> directly. Use it in the headers only when you need the variables in the >>> header. >>> >> Should I include <hugin_config.h> or "hugin_config.h" ? I have seen both >> in the code. >> > > I prefer the "file.h" style for Hugin specific files and <file.h> for > external libs. But this is not used consistent. > > Addition to the includes: >> Every file in hugin1 *except Executor.cpp* which needs >> MAC_SELF_CONTAINED_BUNDLE already includes <config.h>, whose only >> content is #include "hugin_config." So the only needed change would be >> to include <config.h>: >> > > that look good. Also committed to default branch. > > Thomas > > > -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/bc3ca5bd-a8e6-4ed3-b58f-d4bcb4e9d065%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
